New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout in promise race #46

Merged
merged 3 commits into from Mar 29, 2018

Conversation

Projects
None yet
3 participants
@jdneo
Copy link
Member

jdneo commented Mar 26, 2018

If the user click copy & open but doing nothing else. Then the extension will keep waiting for the response. So I added a timeout here.

The 3 minutes is just estimated by myself.

@jdneo

This comment has been minimized.

Copy link
Member

jdneo commented Mar 26, 2018

@chrmarti chrmarti added this to the March 2018 milestone Mar 29, 2018

@chrmarti chrmarti merged commit 6b11143 into Microsoft:master Mar 29, 2018

1 check passed

license/cla All CLA requirements met.
@chrmarti

This comment has been minimized.

Copy link
Contributor

chrmarti commented Mar 29, 2018

Merged with modifications. Thanks!

@jdneo jdneo deleted the jdneo:timeout branch Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment