New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding login support for sovereigns #79

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@yujhongmicrosoft
Copy link
Contributor

yujhongmicrosoft commented Jul 23, 2018

Hey @chrmarti, created a new repo that is insync with current repo and added changes for login support.

@yujhongmicrosoft

This comment has been minimized.

Copy link
Owner

yujhongmicrosoft commented on 69ad902 Jul 23, 2018

Added login support for sovereigns

@@ -26,7 +26,9 @@ import TelemetryReporter from 'vscode-extension-telemetry';
const localize = nls.loadMessageBundle();

const keytar = getNodeModule<typeof keytarType>('keytar');
let currentEnv : AzureEnvironment = (<any>AzureEnvironment).Azure;
let envConfig = vscode.workspace.getConfiguration('azure');

This comment has been minimized.

@chrmarti

chrmarti Aug 2, 2018

Contributor

Move this to getSelectedEnvironment() so it is read at the time it is used.

@@ -102,6 +96,11 @@
"type": "array",
"default": null,
"description": "The resource filter, each element is a tenant id and a subscription id separated by a slash."
},

This comment has been minimized.

@chrmarti

chrmarti Aug 2, 2018

Contributor

Remove this for now, that will hide it from the UI.

@chrmarti

This comment has been minimized.

Copy link
Contributor

chrmarti commented Aug 3, 2018

Had to rebase manually and included the two suggested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment