New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PYTHONPATH on Homebrew #31

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@chrmarti
Copy link
Contributor

chrmarti commented Mar 7, 2018

Less hardcoded paths than in #30.

derekbekoe and others added some commits Mar 6, 2018

@chrmarti chrmarti self-assigned this Mar 7, 2018

@chrmarti

This comment has been minimized.

Copy link
Contributor

chrmarti commented Mar 7, 2018

@derekbekoe Could you take a look at my additions and let me know if that makes sense? Will there be more than one version of packages in .../libexec/lib? Thanks.

@derekbekoe

This comment has been minimized.

Copy link
Contributor

derekbekoe commented Mar 7, 2018

Yes there can be more than one version:

screen shot 2018-03-07 at 9 51 10 am

@chrmarti

This comment has been minimized.

Copy link
Contributor

chrmarti commented Mar 8, 2018

@derekbekoe What about the python folders in .../libexec/lib? Can there be more than one? I wonder if the code to find that could be simplified.

@derekbekoe

This comment has been minimized.

Copy link
Contributor

derekbekoe commented Mar 8, 2018

There will only be one as it's part of the homebrew formula definition. See https://github.com/Homebrew/homebrew-core/blob/ed778ce0ec422a9ff768abbd01dc54f787dadaca/Formula/azure-cli.rb#L486

I would be surprised to see more than one.

@chrmarti

This comment has been minimized.

Copy link
Contributor

chrmarti commented Mar 12, 2018

Merged squashed versions of our commits. Thanks @derekbekoe!

@chrmarti chrmarti closed this Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment