New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site.js appearing in the call stack instead of site.ts #246

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
2 participants
@digeff
Contributor

digeff commented Oct 5, 2017

The code wasn't awaiting, so part of the code to create the response run before resolving the source maps, and the other part after it so we ended up with part saying site.js and part saying site.ts

@roblourens

This comment has been minimized.

Show comment
Hide comment
@roblourens

roblourens Oct 5, 2017

Member

Good catch!

Member

roblourens commented Oct 5, 2017

Good catch!

@roblourens roblourens merged commit e8fd78d into Microsoft:master Oct 5, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
@digeff

This comment has been minimized.

Show comment
Hide comment
@digeff

digeff Oct 5, 2017

Contributor

@roblourens Is there any option for tslint that can catch these kind of things?

Contributor

digeff commented Oct 5, 2017

@roblourens Is there any option for tslint that can catch these kind of things?

@digeff digeff deleted the digeff:fix_incorrect_name_in_callstack branch Oct 5, 2017

@roblourens

This comment has been minimized.

Show comment
Hide comment
@roblourens

roblourens Oct 5, 2017

Member

Not every async function should be awaited, it's tough to know just from looking at the code whether it's right or wrong.

Member

roblourens commented Oct 5, 2017

Not every async function should be awaited, it's tough to know just from looking at the code whether it's right or wrong.

@digeff

This comment has been minimized.

Show comment
Hide comment
@digeff

digeff Oct 5, 2017

Contributor

In C# you call .Forget() to signal that you are "not awaiting it" on purpose...

Contributor

digeff commented Oct 5, 2017

In C# you call .Forget() to signal that you are "not awaiting it" on purpose...

@roblourens roblourens added this to the October 2017 milestone Nov 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment