New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now the start-up timings events can include a failure reason #316

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
2 participants
@digeff
Copy link
Contributor

digeff commented Mar 23, 2018

When we detect that the user requests for an unreachable url, we'll put that in the reason.

This change will break the debug adapters until we update them to use the new parameter required for the new signature.
This is related to this chrome-debug PR: Microsoft/vscode-chrome-debug#630

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Mar 23, 2018

This change will break the debug adapters until we update them to use the new parameter required for the new signature.

Good excuse to bump to 4.0.0 :)

@roblourens roblourens merged commit 6601e3b into Microsoft:master Mar 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@digeff digeff deleted the digeff:add_startup_failure_reason branch Mar 23, 2018

@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment