New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing the context immediately to avoid sending multiple remove eve… #318

Merged
merged 1 commit into from Apr 2, 2018

Conversation

Projects
None yet
2 participants
@rakatyal
Copy link
Member

rakatyal commented Mar 29, 2018

…nts in case of quick refreshes

When we have a case of multiple refreshes in the browser in a quick succession, sometimes we have a case where we don't reach the point of clearing the context and, in turn _scriptById, while sending out 'remove' events from the previous refresh.
In this scenario, the subsequent refresh gets the _scriptsById of the previous state and we end up sending multiple remove events for the same script causing PineZorro to throw an error.

We should clear the context as soon as we populate the cachedScriptParsedEvents array.

@roblourens roblourens self-requested a review Mar 29, 2018

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Mar 29, 2018

@rakatyal I won't merge it this week because we are about to ship vscode. Do you need it published right away? If so, I can merge it to another branch and publish. Just let me know...

@rakatyal

This comment has been minimized.

Copy link
Member

rakatyal commented Mar 29, 2018

@roblourens: Okay. So when can we merge this earliest and get it published via master?

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Mar 29, 2018

End of this week?

@rakatyal

This comment has been minimized.

Copy link
Member

rakatyal commented Mar 29, 2018

Okay I think that will be all right. If we can merge and publish this by EOD tomorrow we will have a week to see we didn't regress anything. Can we do that?

@rakatyal

This comment has been minimized.

Copy link
Member

rakatyal commented Apr 2, 2018

@roblourens: Can we merge and publish this today?

@roblourens roblourens merged commit 8bf1f29 into Microsoft:master Apr 2, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment