New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now we send more telemetry information for some errors #319

Merged
merged 3 commits into from Apr 2, 2018

Conversation

Projects
None yet
2 participants
@digeff
Copy link
Contributor

digeff commented Mar 29, 2018

We want all rejections and throws to be errors so we can get a call stack for telemetry

fix
private _message: DebugProtocol.Message;

constructor (message: DebugProtocol.Message) {
super(message.format);

This comment has been minimized.

@roblourens

roblourens Mar 29, 2018

Member

The error message won't include values inserted with {0}, we should include those, even if we just concatenate them to the end.

this._message = message;
}

public get id(): number {

This comment has been minimized.

@roblourens

roblourens Mar 29, 2018

Member

I think this object needs to be JSON.stringified as a DebugProtocol.Message. I think this will include the message under _message but won't be in the shape of a message?

Maybe just copy all the values off the message onto this?

This comment has been minimized.

@digeff

digeff Apr 2, 2018

Contributor

Done

@roblourens roblourens merged commit 4add51b into Microsoft:master Apr 2, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@digeff digeff deleted the digeff:more_telemetry_on_errors branch Apr 2, 2018

@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment