Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update noice to latest version #320

Merged
merged 1 commit into from Apr 4, 2018

Conversation

@digeff
Copy link
Contributor

commented Apr 4, 2018

When the latest version fails it rejects the promises with actual errors, so we'll get stack traces on telemetry if something goes wrong.

@roblourens

This comment has been minimized.

Copy link
Member

commented Apr 4, 2018

Thanks for getting that in

@roblourens roblourens merged commit 81247d7 into microsoft:master Apr 4, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@roblourens roblourens added this to the April 2018 milestone Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.