Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize stack traces so they don't contain full file paths #322

Merged
merged 2 commits into from Apr 6, 2018

Conversation

@digeff
Copy link
Contributor

commented Apr 6, 2018

Sanitize stack traces so they don't contain full file paths

@roblourens
Copy link
Member

left a comment

I don’t think the try/catch is necessary, .replace shouldn’t throw. I'll leave it for now. I'll fix this up for non-windows too.

@roblourens roblourens merged commit 97d90cc into microsoft:master Apr 6, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@digeff digeff deleted the digeff:sanitize_stack_traces branch Apr 6, 2018

@roblourens roblourens added this to the April 2018 milestone Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.