Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore bp resolved for unknown script #325

Merged

Conversation

@digeff
Copy link
Contributor

commented Apr 25, 2018

Edge reports the breakpointResolved event even when the setBreakpointByUrl call can resolve the breakpoint immediately. That results on onBreakpointResolved being called with a breakpointId it doesn't recognize, and sending an incorrect event to VS Code which makes the breakpoints stop working properly.
Until the extra breakpointResolved gets fixed on Edge, this workaround will prevent us from emitting the event without a valid breakpointId to the client.

@digeff digeff force-pushed the digeff:ignore_bp_resolved_for_unknown_script branch from 6abfb88 to b567846 Apr 26, 2018

@roblourens roblourens merged commit 6a81471 into microsoft:master Apr 27, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@digeff digeff deleted the digeff:ignore_bp_resolved_for_unknown_script branch Apr 27, 2018

@roblourens roblourens added this to the April 2018 milestone Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.