New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix break-on-load to make breakpoints on attach work #332

Merged
merged 5 commits into from Sep 26, 2018

Conversation

Projects
None yet
3 participants
@digeff
Contributor

digeff commented Jun 4, 2018

  • Move this._breakOnLoadHelper to common args so break on load can be used for both launch and attach
  • Update the logic of getUrlRegexForBreakOnLoad to handle case insensitive paths
    • Pass caseSensitivePaths around which is an argument of the case insensitive path logic

This as final bug-fixes. At this moment we are using this change as a temporary-workaround to fix the NTVS unit tests

@digeff

This comment has been minimized.

Show comment
Hide comment
@digeff

digeff Jun 4, 2018

Contributor

@rakatyal PTAL

Contributor

digeff commented Jun 4, 2018

@rakatyal PTAL

@roblourens

This comment has been minimized.

Show comment
Hide comment
@roblourens

roblourens Jun 24, 2018

Member

Is this still valid? Are you going to review it @rakatyal?

Member

roblourens commented Jun 24, 2018

Is this still valid? Are you going to review it @rakatyal?

@rakatyal

This comment has been minimized.

Show comment
Hide comment
@rakatyal

rakatyal Jun 25, 2018

Member

@roblourens: Yes I believe this is still valid but we are not planning to ship this at the moment. I will review this soon.

Member

rakatyal commented Jun 25, 2018

@roblourens: Yes I believe this is still valid but we are not planning to ship this at the moment. I will review this soon.

@digeff

This comment has been minimized.

Show comment
Hide comment
@digeff

digeff Sep 24, 2018

Contributor

@roblourens @rakatyal We are planning on using this PR for VS 16. Could you please review it now?

Contributor

digeff commented Sep 24, 2018

@roblourens @rakatyal We are planning on using this PR for VS 16. Could you please review it now?

@roblourens

This comment has been minimized.

Show comment
Hide comment
@roblourens

roblourens Sep 26, 2018

Member

@rakatyal are you going to review this?

Member

roblourens commented Sep 26, 2018

@rakatyal are you going to review this?

@rakatyal

This comment has been minimized.

Show comment
Hide comment
@rakatyal

rakatyal Sep 26, 2018

Member

@roblourens: Yes I will do this today. Apologies for missing this earlier.

Member

rakatyal commented Sep 26, 2018

@roblourens: Yes I will do this today. Apologies for missing this earlier.

@roblourens

Thanks for the PR and for including so many tests!

@roblourens roblourens merged commit 674f0cb into Microsoft:master Sep 26, 2018

2 checks passed

license/cla All CLA requirements met.
Details
vscode-chrome-debug-core-CI #20180926.1 succeeded
Details

@digeff digeff deleted the digeff:fix_ntvs_unit_tests branch Sep 26, 2018

@roblourens roblourens added this to the September 2018 milestone Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment