New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe array access in internalSourceBreakpoint #335

Merged
merged 1 commit into from Jun 17, 2018

Conversation

Projects
None yet
2 participants
@jhnns
Contributor

jhnns commented Jun 16, 2018

The stackTrace.callFrames property of the Protocol.Runtime.ConsoleAPICalledEvent can be an empty array in certain conditions.

See #334

Fix unsafe array access in internalSourceBreakpoint
The stackTrace.callFrames property of the
Protocol.Runtime.ConsoleAPICalledEvent
can be an empty array in certain conditions.
See #334
@roblourens

This comment has been minimized.

Member

roblourens commented Jun 17, 2018

Thanks for the PR!

@roblourens roblourens merged commit 6608d00 into Microsoft:master Jun 17, 2018

1 check passed

license/cla All CLA requirements met.

@jhnns jhnns deleted the jhnns:fix/unsafe-array-access branch Jun 18, 2018

@roblourens roblourens added this to the June 2018 milestone Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment