New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging mechanism to not log sources #355

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@digeff
Contributor

digeff commented Sep 18, 2018

Update logging mechanism to not log sources

@roblourens

This comment has been minimized.

Show comment
Hide comment
@roblourens

roblourens Sep 19, 2018

Member

Can you file an issue and include more details about what you are trying to do and why? Even though this is a relatively simple change please don't make me or other contributors reverse engineer the intent of this from the diff.

Member

roblourens commented Sep 19, 2018

Can you file an issue and include more details about what you are trying to do and why? Even though this is a relatively simple change please don't make me or other contributors reverse engineer the intent of this from the diff.

public sendResponse(response: DebugProtocol.Response): void {
const originalLogVerbose = logger.verbose;
try {
logger.verbose = textToLog => {

This comment has been minimized.

@roblourens

roblourens Sep 19, 2018

Member

Hm, what would be a better way to allow customizing the logged message?

Maybe the logger could call a method on DebugSession that formats the string for logging, and it can be overridden here?

@roblourens

roblourens Sep 19, 2018

Member

Hm, what would be a better way to allow customizing the logged message?

Maybe the logger could call a method on DebugSession that formats the string for logging, and it can be overridden here?

This comment has been minimized.

@roblourens

roblourens Sep 19, 2018

Member

I filed Microsoft/vscode-debugadapter-node#201 on myself to follow up.

@roblourens

roblourens Sep 19, 2018

Member

I filed Microsoft/vscode-debugadapter-node#201 on myself to follow up.

@roblourens roblourens added this to the September 2018 milestone Sep 19, 2018

@roblourens roblourens merged commit 8f8724f into Microsoft:master Sep 19, 2018

2 checks passed

license/cla All CLA requirements met.
Details
vscode-chrome-debug-core-CI #20180918.1 succeeded
Details

@digeff digeff deleted the digeff:dont_log_sources branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment