New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for basic color escape sequencies on Debug Console #367

Merged
merged 3 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@rdegelo
Contributor

rdegelo commented Oct 12, 2018

Added support for bold font style on Debug Console.

Background color can be easily implemented using the same approach.
If this PR gets accepted, I can add background colors support.

Renato Degelo
Added basic color escape sequencies on Debug Console
Added support for bold font style on Debug Console
@msftclas

This comment has been minimized.

msftclas commented Oct 12, 2018

CLA assistant check
All CLA requirements met.

@rdegelo

This comment has been minimized.

Contributor

rdegelo commented Oct 12, 2018

Renato Degelo
@roblourens

This comment has been minimized.

Member

roblourens commented Oct 17, 2018

This looks great, but the font-weight doesn't appear to have any affect in the Debug Console. Is it working for you? I don't know whether vscode supports it.

@rdegelo

This comment has been minimized.

Contributor

rdegelo commented Oct 17, 2018

It works for me:

console.log('%c Normal font weight ', 'color: blue');
console.log('%c Normal font weight ', 'color: blue; font-weight: bold');

Result:
image

To check what is supported, you can see this file:
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/browser/debugANSIHandling.ts#L70

@roblourens

This comment has been minimized.

Member

roblourens commented Oct 17, 2018

I see it, the problem is that the debug console uses the Monaco font on macos, which doesn't support a bold font weight. Will take that upstream...

@rdegelo

This comment has been minimized.

Contributor

rdegelo commented Oct 17, 2018

Cool,
When I have time I'll add background/underline support and post a new PR.

@roblourens roblourens merged commit c1d4532 into Microsoft:master Oct 17, 2018

2 checks passed

license/cla All CLA requirements met.
Details
vscode-chrome-debug-core-CI #20181017.1 succeeded
Details

@roblourens roblourens added this to the October 2018 milestone Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment