New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node not hitting breakpoints in network paths #368

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@digeff
Contributor

digeff commented Oct 15, 2018

We couldn't hit a breakpoint in:
\myshare\myfolder\myfile.js

@roblourens

This comment has been minimized.

Member

roblourens commented Oct 15, 2018

// Breakpoints need to be re-set when break-on-load is enabled

Why? We guessed at the path, that path was correct right? What's the real issue here? I don't see how breakOnLoad or network paths are involved.

@digeff

This comment has been minimized.

Contributor

digeff commented Oct 16, 2018

We guessed at the path, but we never set that breakpoint with that path (With break-on-load we set the break-on-load breakpoint instead of the real breakpoint, we need to set the real-breakpoint when parse the script).

@roblourens

This comment has been minimized.

Member

roblourens commented Oct 16, 2018

Oh I see. The disconnect between BreakOnLoadHelper, and this check that makes assumptions about what the helper did, feels a little awkward. But I think this is ok.

@roblourens roblourens merged commit 6195e50 into Microsoft:master Oct 16, 2018

2 checks passed

license/cla All CLA requirements met.
vscode-chrome-debug-core-CI #20181015.1 succeeded
Details
@roblourens

This comment has been minimized.

Member

roblourens commented Oct 16, 2018

Published -core

@digeff digeff deleted the digeff:fix_node_network_path branch Oct 16, 2018

@roblourens roblourens added this to the October 2018 milestone Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment