New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We adapt to the latest version of Node.js which uses file:/// and we don't send sourceRef for files that exist #373

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@digeff
Contributor

digeff commented Oct 23, 2018

We adapt to the latest version of Node.js which uses file:/// and we don't send sourceRef for files that exist

In Node v11 it adds file:/// to script urls. That made existAsync return false, we sent the sourceRef to VS which assumes that the file is not on disk because of that, and causes breakpoints to not be shown properly.

We use the canonicalized version which removes file:/// to fix that issue

We adapt to the latest version of Node.js which uses file:/// and we …
…don't send sourceRef for files that exist
@roblourens

Good catch

@roblourens roblourens merged commit 091b3f0 into Microsoft:master Oct 23, 2018

2 checks passed

license/cla All CLA requirements met.
vscode-chrome-debug-core-CI #20181023.1 succeeded
Details

@roblourens roblourens added this to the October 2018 milestone Oct 23, 2018

@digeff digeff deleted the digeff:fix_sending_sourceref_for_existing_files branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment