Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send src changed events for storage sources #378

Merged
merged 1 commit into from Nov 7, 2018

Conversation

@digeff
Copy link
Contributor

commented Nov 6, 2018

Edge has incremental loading, so it can send several "loadsources" events for the same file.

VS is strict about the notification it receives. It tracks the changes to files on storage on it's own, so it'll show an error message if we send a changed event for a file on storage. Given that VS Code also tracks changes to files in storage on it's own, it makes sense to just filter those notifications and never send them.

This fixes an issue we were running into with Edge and VS

@roblourens roblourens merged commit 1614fcf into microsoft:master Nov 7, 2018

2 checks passed

license/cla All CLA requirements met.
vscode-chrome-debug-core-CI #20181106.1 succeeded
Details

@digeff digeff deleted the digeff:fix_src_changed_event branch Nov 7, 2018

@roblourens roblourens added this to the November 2018 milestone Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.