New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now we report the times of the different tasks that happen until we launch and show the user page #610

Merged
merged 6 commits into from Mar 12, 2018

Conversation

Projects
None yet
2 participants
@digeff
Copy link
Contributor

digeff commented Mar 8, 2018

Now we report the times of the different tasks that happen until we launch and show the user page

digeff added some commits Feb 27, 2018

@digeff digeff force-pushed the digeff:launch_timings_telemetry_master branch from 96541b5 to c9215ec Mar 10, 2018

if (this._userRequestedUrl) {
// This means all the setBreakpoints requests have been completed. So we can navigate to the original file/url.
this.chrome.Page.navigate({ url: this._userRequestedUrl });
this.events.emitMilestoneReached("RequestedNavigateToUserPage");

This comment has been minimized.

@roblourens

roblourens Mar 10, 2018

Member

Wait on the navigate before sending the event? Maybe don't await so it doesn't block configurationDone. But just like Page.navigate(...).then(() => emitMilestoneReached())

digeff added some commits Mar 10, 2018

@roblourens roblourens merged commit 449d8e5 into Microsoft:master Mar 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@digeff digeff deleted the digeff:launch_timings_telemetry_master branch Mar 12, 2018

@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment