New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser version to telemetry #621

Merged
merged 2 commits into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@digeff
Copy link
Contributor

digeff commented Mar 16, 2018

Add browser version to telemetry

This is dependent on this PR: Microsoft/vscode-chrome-debug-core#307

@@ -172,10 +172,23 @@ export class ChromeDebugAdapter extends CoreDebugAdapter {

protected doAttach(port: number, targetUrl?: string, address?: string, timeout?: number, websocketUrl?: string, extraCRDPChannelPort?: number): Promise<void> {
return super.doAttach(port, targetUrl, address, timeout, websocketUrl, extraCRDPChannelPort).then(() => {
const userAgentPromise = this.globalEvaluate({ expression: 'navigator.userAgent', silent: true }).then(evalResponse => evalResponse.result.value);

This comment has been minimized.

This comment has been minimized.

@digeff

digeff Mar 16, 2018

Contributor

Thanks, I didn't know that existed.

@roblourens roblourens merged commit 3007fcc into Microsoft:master Mar 20, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Details

@digeff digeff deleted the digeff:add_browser_version_to_telemetry branch Mar 20, 2018

@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment