New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the msbuild signing project to remove unwanted files #622

Merged
merged 9 commits into from Mar 19, 2018

Conversation

Projects
None yet
2 participants
@msft-cwells
Copy link
Contributor

msft-cwells commented Mar 16, 2018

Removes the dll, pdb, and zip files, which we don't want in the published NuGet package.

$(OutDir)node_modules\resolve\test\resolver\mug.js;
$(OutDir)node_modules\resolve\test\pathfilter\deep_ref\main.js;
$(OutDir)node_modules\resolve\test\resolver\baz\doom.js;
$(OutDir)node_modules\vsce\node_modules\tmp\test\symlinkme\file.js;

This comment has been minimized.

@roblourens

roblourens Mar 16, 2018

Member

I'm curious where this list of node_modules comes from?

This comment has been minimized.

@msft-cwells

msft-cwells Mar 19, 2018

Contributor

That's really the list of files that cause the signing step to fail...but interestingly, they cause the signing step to fail because they are empty JS files (and apparently the signing tool refuses to append our Authenticode cert block to an empty *.js file).

I think we've found a way to simplify some of this process, so hopefully we'll be able to remove that exclusion list in the near future.

This comment has been minimized.

@roblourens

roblourens Mar 19, 2018

Member

These all appear to be devDependencies, which don't need to be shipped. I would recommend not shipping any devDependencies, it will make the released version much smaller!

This comment has been minimized.

@msft-cwells

msft-cwells Mar 19, 2018

Contributor

Indeed. One of the effects of our planned simplification change will be to not copy/sign/package/ship devDependencies. Thanks Rob!

@roblourens roblourens merged commit b1192af into Microsoft:master Mar 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment