New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now we provide a reason of why start-up failed #630

Merged
merged 3 commits into from Mar 26, 2018

Conversation

Projects
None yet
2 participants
@digeff
Copy link
Contributor

digeff commented Mar 23, 2018

When we are asked to go to an unreachable url, we'll add that information to the start-up timings telemetry.

This PR requires this -core PR: Microsoft/vscode-chrome-debug-core#316

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Mar 23, 2018

Merge conflicts

// Chrome started to navigate to the user's requested url
this.events.emit(ChromeDebugSession.FinishedStartingUpEventName);
this.events.emit(ChromeDebugSession.FinishedStartingUpEventName, { requestedContentWasDetected: true } as FinishedStartingUpEventArguments);

This comment has been minimized.

@roblourens

roblourens Mar 23, 2018

Member

Do these all need a cast?

This comment has been minimized.

@digeff

digeff Mar 23, 2018

Contributor

I use the cast to make sure I'm sending the right properties.
If I don't put the cast, the object is of type any, and anything is considered valid.
If I put the cast, then the compiler will fail if I don't put the valid properties here.

This comment has been minimized.

@roblourens

roblourens Mar 24, 2018

Member

I was thinking 'emit' was typed here

@digeff digeff force-pushed the digeff:startup_fail_reason branch from 3331046 to a2a5c18 Mar 23, 2018

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Mar 24, 2018

Check CI?

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Mar 24, 2018

Please do this for node2 also

@roblourens roblourens merged commit a5611dc into Microsoft:master Mar 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@digeff digeff deleted the digeff:startup_fail_reason branch Mar 26, 2018

@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment