New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set chrome PID in all launch cases #687

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
2 participants
@mrcrane
Member

mrcrane commented Jun 20, 2018

Fixes an issue where the chrome PID was not set in some situations. In Visual Studio, without setting the PID, the chrome process will not terminate properly.

@roblourens

Thanks!

@roblourens roblourens merged commit edd9680 into Microsoft:master Jun 20, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@roblourens roblourens added this to the June 2018 milestone Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment