Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS Lint Rule name to lint markers. #116

Merged
merged 1 commit into from Aug 22, 2018

Conversation

@connorshea
Copy link
Contributor

commented Aug 21, 2018

Resolves microsoft/vscode#56925

Before:
screen shot 2018-08-21 at 2 16 06 pm
screen shot 2018-08-21 at 2 16 15 pm

After:
screen shot 2018-08-21 at 2 10 55 pm
screen shot 2018-08-21 at 2 11 09 pm

The rule name doesn't include the css.lint.* prefix, but that isn't included in the Rule object that marker.getRule() returns. That can be worked around using document.languageId but I'm fairly sure that'd break on some edge cases.

@aeschli aeschli merged commit d330721 into microsoft:master Aug 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
@aeschli

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2018

Thanks @connorshea !

@aeschli aeschli added this to the August 2018 milestone Aug 22, 2018

@connorshea connorshea deleted the connorshea:add-css-lint-rule-to-hover branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.