New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show specificity in a css selector hover. #129

Merged
merged 7 commits into from Oct 29, 2018

Conversation

Projects
None yet
4 participants
@Ragnoroct
Contributor

Ragnoroct commented Oct 25, 2018

This is a pull request to show the specificity score of a css selector on hover.

@msftclas

This comment has been minimized.

msftclas commented Oct 25, 2018

CLA assistant check
All CLA requirements met.

@Ragnoroct

This comment has been minimized.

Contributor

Ragnoroct commented Oct 25, 2018

I'm kind of new to this. How do I reference Microsoft/vscode#7299 with this pull request while I'm working on it?

EDIT: Ahhh. I guess I did it indirectly. 😄

@Ragnoroct

This comment has been minimized.

Contributor

Ragnoroct commented Oct 25, 2018

I can fix the unit tests Saturday morning.

@Ragnoroct Ragnoroct changed the title from WIP: First attempt at showing specificity in a css selector hover. to Show specificity in a css selector hover. Oct 27, 2018

@Ragnoroct

This comment has been minimized.

Contributor

Ragnoroct commented Oct 27, 2018

@aeschli I'm finished with this and all the tests pass. Do I need to do anything else to get this into vscode?

kumarharsh and others added some commits Oct 28, 2018

Fix typo
Co-Authored-By: Ragnoroct <willypbender83@gmail.com>
Fix typo
Co-Authored-By: Ragnoroct <willypbender83@gmail.com>
@Ragnoroct

This comment has been minimized.

Contributor

Ragnoroct commented Oct 28, 2018

@kumarharsh Thank you. I've applied your suggested code changes to fix the typos.

@aeschli

This comment has been minimized.

Contributor

aeschli commented Oct 29, 2018

Very cool, thanks, @Ragnoroct !

@aeschli aeschli merged commit 962cad6 into Microsoft:master Oct 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@aeschli aeschli added this to the October 2018 milestone Oct 29, 2018

@aeschli

This comment has been minimized.

Contributor

aeschli commented Oct 29, 2018

I made some minor improvements: 0bba3ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment