New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename specificity label and add a link to MDN #131

Merged
merged 2 commits into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@tlent
Contributor

tlent commented Oct 30, 2018

Fixes Microsoft/vscode#62155

I renamed it "Selector specificity" instead of "CSS specificity" because the user would already know they are editing a CSS file and "Selector specificity" seemed like a better description.

I wasn't sure if the link should be included in the localize() call or not. MDN has that page in other languages so maybe it should be localized to link to the appropriate language page? If this is not how it should be done I can change it.

This is my first VS Code related contribution. I hope that it is helpful.

@msftclas

This comment has been minimized.

msftclas commented Oct 30, 2018

CLA assistant check
All CLA requirements met.

@octref octref force-pushed the tlent:specificity-label branch from afda73a to c21a107 Oct 31, 2018

@octref

This comment has been minimized.

Member

octref commented Oct 31, 2018

I made some changes and pulled it in. Mainly because of the merge conflicts.

Thanks again for the PR and don't forget to get your Microsoft shirt for Hacktoberfest! Today is the last day. https://open.microsoft.com/2018/09/30/join-hacktoberfest-2018-celebration-microsoft/

@octref octref merged commit 97755f7 into Microsoft:master Oct 31, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details

@octref octref added this to the October 2018 milestone Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment