Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Support for Less root functions, lookups, anonymous mixins #135
This fixes a number of errors in the language service parser for CSS/Less (that are not covered in Microsoft/vscode#43087).
* The declaration of
This was referenced
Dec 2, 2018
One thing that's still kind of outstanding is that because rulesets can be maps in Less, the warning and squiggly lines about "unknown property"s is somewhat useless. Is there a way for those
octref left a comment
That's fine for now.
Overall looks good, just a few questions to understand the less features being added.
referenced this pull request
Jan 4, 2019
@matthew-dean Thanks a lot for your help! We're happy to have your expertise!
Most of the changes are good. To (hopefully) make it simpler to work on this, I already pushed some of the uncontroversial changes, see 5e7a590
What I don't like so much are changes related to the map lookups. The lookup is modelled as a child to variables and mixins. I think it is cleaner if we do it in the term, like an an operator (e.g. the % operator).
I'm unclear what you're saying...?
added a commit
this pull request
Jan 10, 2019
@matthew-dean My suggestion would be to add the support to
That allows indexed access of every term which is probably more than necessary, but would keep the variables and mixins as is.