New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn for unknown properties inside an :export block #137

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
4 participants
@kristerkari
Copy link
Contributor

kristerkari commented Dec 10, 2018

Currently custom properties inside a CSS modules :export block are reported as unknown. The properties inside :export are not CSS properties - they are custom properties that are exported from the CSS/SCSS file to Javascript (e.g. variables).

This PR adds a simple check to see if the selector is :export, and skips the whole checking for unknown properties in that case.

Please enable Diff settings > hide whitespace changes from Github's UI when reviewing the PR.

fixes #103

@msftclas

This comment has been minimized.

Copy link

msftclas commented Dec 10, 2018

CLA assistant check
All CLA requirements met.

@kristerkari

This comment has been minimized.

Copy link
Contributor Author

kristerkari commented Dec 16, 2018

Anyone to review this @aeschli @octref ?

@octref octref added this to the December 2018 milestone Dec 16, 2018

@octref

This comment has been minimized.

Copy link
Member

octref commented Dec 16, 2018

Sorry both of us was on vacation. I'll review it in December.

@kristerkari

This comment has been minimized.

Copy link
Contributor Author

kristerkari commented Dec 16, 2018

Thanks! Have nice holidays

@octref

This comment has been minimized.

Copy link
Member

octref commented Jan 2, 2019

LGTM. Thanks for your contribution!

@octref octref merged commit d72b06f into Microsoft:master Jan 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@kristerkari kristerkari deleted the kristerkari:css-modules-export branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment