Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css-schema.xml to support CSS Grid #28

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
4 participants
@lannonbr
Copy link
Contributor

lannonbr commented May 16, 2017

Fixed Microsoft/vscode#13595.

@msftclas

This comment has been minimized.

Copy link

msftclas commented May 16, 2017

@lannonbr,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas

This comment has been minimized.

Copy link

msftclas commented May 16, 2017

@lannonbr, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@msftclas msftclas added cla-signed and removed cla-required labels May 16, 2017

@aeschli aeschli merged commit 885ef3f into Microsoft:master May 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented May 25, 2017

Thanks @lannonbr !
As mentioned there is the danger that these changes get overwritten once we connect to the latest data sources. This is not planned for comming next months tough.

@aeschli aeschli added this to the May 2017 milestone May 25, 2017

@aeschli aeschli self-assigned this May 25, 2017

@lannonbr lannonbr deleted the lannonbr:css-grid-support branch May 25, 2017

@karocksjoelee

This comment has been minimized.

Copy link

karocksjoelee commented Aug 2, 2017

I am using the latest version of vs code , does this updated ??
cause I am still getting [css] unknown property warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.