New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode-website] Turn off hidden animation for "Skip to content" link #1131

Closed
gilmoreorless opened this Issue Aug 17, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@gilmoreorless
Contributor

gilmoreorless commented Aug 17, 2017

Note: This issue affects the whole site, not just the docs, but I'm raising the issue here because the vscode-website repo is not public.

I'd noticed that my computer's CPU usage was increasing every time I was viewing a page on https://code.visualstudio.com/. After digging into it I found there's a hidden "Skip to content" link which appears when tabbing to it. This is great for accessibility, however within the link is an icon:
image
The icon has a 0.5 second looping animation that infinitely moves the icon up and down by 3 pixels. This animation is causing the browser to take up a non-trivial amount of CPU usage.

Given that the animated icon is only visible when the link has focus via the keyboard, and the link itself is a feature for screenreader users, is there any use in having the animation?
I'd prefer if the animation was removed, but obviously I don't have the final say. 😉

@gregvanl gregvanl added this to the September 2017 milestone Sep 11, 2017

@gregvanl gregvanl modified the milestones: September 2017, October 2017 Oct 2, 2017

@gregvanl

This comment has been minimized.

Contributor

gregvanl commented Oct 12, 2017

This issue was moved to Microsoft/vscode-website#684

@gregvanl gregvanl closed this Oct 12, 2017

@gregvanl

This comment has been minimized.

Contributor

gregvanl commented Oct 12, 2017

@gilmoreorless Thank you for creating the issue. I moved it to vscode-website and will reply back here when the issue is fixed.

@gilmoreorless

This comment has been minimized.

Contributor

gilmoreorless commented Oct 12, 2017

Thanks @gregvanl!

@octref

This comment has been minimized.

Member

octref commented Nov 8, 2017

Thanks for pointing out. This is fixed and will be published to website soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment