Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslintignore comment syntax highlighting #473

Merged
merged 2 commits into from Aug 20, 2018

Conversation

@Hirse
Copy link
Contributor

commented May 24, 2018

Colors comments and enables commenting of lines using keyboard shortcut.

see #459

@dbaeumer

This comment has been minimized.

Copy link
Member

commented May 25, 2018

@aeschli can you please have a quick review. You know a lot more about this than I do.

@dbaeumer dbaeumer requested a review from aeschli May 25, 2018

@aeschli

This comment has been minimized.

Copy link

commented May 25, 2018

The change looks good!

@Hirse If you wanted you could make a similar addition for gitignore files as we don't have any colorization there as well.
We could share the grammar of the two, if we're sure that the syntaxes are identical.

@Hirse

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2018

@aeschli Do you mean in vscode?
If we add that, would it make sense to define some kind of generic ignore-file language for gitignore, eslintignore, npmignore, and possibly others?

@aeschli

This comment has been minimized.

Copy link

commented May 28, 2018

@Hirse A generic ignore-file language makes sense. We could still place it along with the git extension

@dbaeumer

This comment has been minimized.

Copy link
Member

commented May 28, 2018

That makes sense to me as well. That would mean for eslint we would then simply reference the genernal syntax.

@Hirse

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2018

@aeschli do you mean adding a definition in vscode extensions/git/languages or adding a new ignore extension which only contains this language definition?

@aeschli

This comment has been minimized.

Copy link

commented May 29, 2018

@Hirse I'd suggest to add it to vscode/extensions/git

@dbaeumer

This comment has been minimized.

Copy link
Member

commented May 30, 2018

@aeschli do you recommend that we wait with this in ESLint and then reuse the one that goes into git?

@Hirse Hirse referenced this pull request Jun 3, 2018

Merged

Add gitignore language #51026

@Hirse Hirse force-pushed the Hirse:master branch from d1c4fa7 to b9b1359 Aug 14, 2018

@Hirse Hirse force-pushed the Hirse:master branch from b9b1359 to 1e6f9cb Aug 14, 2018

@Hirse

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

@dbaeumer Sorry for the delay, I have changed the code to reference the existing ignore language as @aeschli did in microsoft/vscode@eb2b51a so this should be good to go now.

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Aug 20, 2018

Thanks!.

@dbaeumer dbaeumer merged commit 25b03e8 into microsoft:master Aug 20, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.