Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the node runtime to use for the language server. Fixes #345 #516

Merged
merged 2 commits into from Aug 22, 2018

Conversation

@Mossop
Copy link
Contributor

commented Aug 10, 2018

Per the discussion in #345 it is useful toi be able to select the node version to run ESLint as. This adds the eslint.server.runtime setting which can be set to the path of the node binary to use.

@msftclas

This comment has been minimized.

Copy link

commented Aug 10, 2018

CLA assistant check
All CLA requirements met.

@Mossop

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2018

I'm not really sure what the travis failures are all about, they seem unrelated to my changes :(

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Aug 20, 2018

@Mossop nice work. One minor request. Can we name the setting eslint.runtime (without server). There are other server settings that don't have server in its name (like eslint.nodePath).

README.md Outdated
@@ -22,6 +22,7 @@ This extension contributes the following variables to the [settings](https://cod
```
- `eslint.run` - run the linter `onSave` or `onType`, default is `onType`.
- `eslint.autoFixOnSave` - enables auto fix on save. Please note auto fix on save is only available if VS Code's `files.autoSave` is either `off`, `onFocusChange` or `onWindowChange`. It will not work with `afterDelay`.
- `eslint.server.runtime` - use this setting to set the path of the node runtime to run ESLint under.

This comment has been minimized.

Copy link
@dbaeumer

dbaeumer Aug 20, 2018

Member

I suggest to name this eslint.runtime. eslint.nodePath is for the server as well and we never put server into the naming so far.

@dbaeumer dbaeumer added this to the August 2018 milestone Aug 20, 2018

@dbaeumer dbaeumer merged commit 9947528 into microsoft:master Aug 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.