New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline #569

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@angulito
Copy link
Contributor

angulito commented Oct 31, 2018

Improve the pipeline using jobs instead of a single script to build all the pipeline commands.

Also I've splitted the npm run compile to run the compile:client and compile:server so it's easier to find if there is any compile problem.

See pipeline example -> https://travis-ci.org/angulito/vscode-eslint/builds/448863504

@@ -4,8 +4,12 @@ sudo: false
node_js:
- "6.11.2"

install:
- npm install

This comment has been minimized.

@dbaeumer

dbaeumer Nov 1, 2018

Member

How do we now make sure npm install is executed. I have to admit that I am not very familiar with pipelines :-)

This comment has been minimized.

@angulito

angulito Nov 5, 2018

Contributor

You can see an example here
image

The fact is if you have jobs in the pipeline, they are related to the language - it means travis ci knows what are the default steps for the javascript/nodejs language:
to install: npm install
to run the tests: npm tests
and for each job, the pipeline always runs the default command for the install step, in this case, npm install.

For that reason you can see here that for the compile client and compile server jobs, travisCI runs the npm install command inside (and you cannot see that command declared in the pipeline)

This comment has been minimized.

@dbaeumer

dbaeumer Nov 6, 2018

Member

Thanks for the explanation !

@dbaeumer dbaeumer merged commit 2124b91 into Microsoft:master Nov 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@angulito angulito deleted the angulito:improve_pipeline branch Nov 20, 2018

@angulito angulito restored the angulito:improve_pipeline branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment