New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 529, Added support for pnpm #572

Merged
merged 3 commits into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@Lee182
Copy link
Contributor

Lee182 commented Nov 4, 2018

No description provided.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 4, 2018

CLA assistant check
All CLA requirements met.

Lee182 added some commits Nov 4, 2018

@dbaeumer dbaeumer self-assigned this Nov 5, 2018

@dbaeumer dbaeumer added this to the On Deck milestone Nov 5, 2018

npm: {
cache: undefined,
get(): string {
const npmPath = execSync('npm root -g').toString().trim();

This comment has been minimized.

@dbaeumer

dbaeumer Nov 21, 2018

Member

Can we keep using Files.resolveGlobalNodePath here to make sure we are not breaking anything.

This comment has been minimized.

@Lee182

Lee182 Nov 21, 2018

Author Contributor

Yeah that's fine 👍

@dbaeumer
Copy link
Member

dbaeumer left a comment

The PR looks good to me except the two comments I have.

@dbaeumer dbaeumer merged commit 627935c into Microsoft:master Dec 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
const packageManager = Workspace.getConfiguration('eslint', uri).get('packageManager', 'npm');
const localInstall = {
npm: 'npm install eslint',
pnpm: 'pnpm install pnpm',

This comment has been minimized.

@TomasHubelbauer

TomasHubelbauer Jan 3, 2019

Shouldn't this say pnpm install eslint?

This comment has been minimized.

@dbaeumer

dbaeumer Jan 8, 2019

Member

Correct. Will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment