New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable-eslint fixes and improvements #588

Merged
merged 5 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@loune
Copy link
Contributor

loune commented Dec 13, 2018

  • Fix issue with 'Fix all rule' quick action not appearing (mentioned in comment of #530)
  • Add setting eslint.suppressCodeActionComment with options sameLine or newLine (#573)
  • Add setting eslint.showSuppressCodeAction comment of #530
  • Add setting eslint.showDocumentationCodeAction comment of #530

loune added some commits Dec 10, 2018

Add eslint.suppressCodeActionComment
Add eslint.showSuppressCodeAction
Add eslint.showDocumentationCodeAction

@loune loune changed the title Disable eslint fixes disable-eslint fixes and improvements Dec 13, 2018

@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Dec 17, 2018

@loune thanks for the PR. See my comments in the review.

@dbaeumer dbaeumer self-requested a review Dec 17, 2018

@dbaeumer
Copy link
Member

dbaeumer left a comment

I would suggest that we group the settings a little. Proposal is:

eslint.codeAction.suppressComment: {
   enable: boolean;
   location: 'newLine' | 'sameLine';
}

eslint.codeAction.showDocumentation: {
    enable: boolean;
}
@loune

This comment has been minimized.

Copy link
Contributor Author

loune commented Dec 29, 2018

@dbaeumer Changes have been made. Cheers

@dbaeumer dbaeumer merged commit 89c2e66 into Microsoft:master Jan 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Jan 8, 2019

@loune thanks. I merged it in and did some minor polish in regards to naming.

	"eslint.codeAction.showDocumentation": {
		"enable": false
	},
	"eslint.codeAction.disableRuleComment": {
		"enable": true,
		"location": "separateLine"
	}

Called it disable instead of suppress since ESLint itself uses disable.

@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Jan 8, 2019

I also improved the ordering of the actions.

@loune

This comment has been minimized.

Copy link
Contributor Author

loune commented Jan 9, 2019

Thanks @dbaeumer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment