New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't download Code every time on Windows #102

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
2 participants
@DanTup
Copy link
Contributor

DanTup commented Mar 20, 2018

The exists check further down fails to find the executable on Windows because the real filename has .exe on the end. This means it downloads over and over again (which can be significant if you run this script multiple times to test different workspace folders).

Fixes #100.

Don't download Code every time on Windows
The `exists` check further down fails to find the executable on Windows because the real filename has `.exe` on the end. This means it downloads over and over again (which can be significant if you run this script multiple times to test different workspace folders).

@bpasero bpasero merged commit 58cff35 into Microsoft:master Mar 20, 2018

1 check passed

license/cla All CLA requirements met.
@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Mar 20, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment