New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bin #75

Merged
merged 1 commit into from Oct 12, 2017

Conversation

Projects
None yet
2 participants
@donaldpipowitch
Contributor

donaldpipowitch commented Sep 29, 2017

Hi, I added install to the "bin" in package.json. I'd like to get rid of the hard coded path used in the lsp-sample (and my own projects). As you know the path can be a little bit error prone between different npm clients and projects structures. (I currently use yarn with workspaces for a VS Code extension and it looks really nice. This is just on of those small gotchas I found.)

@bpasero bpasero merged commit 86f9f59 into Microsoft:master Oct 12, 2017

1 check passed

license/cla All CLA requirements met.
@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Oct 12, 2017

Member

Thanks

Member

bpasero commented Oct 12, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment