New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies. #79

Merged
merged 2 commits into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@JimiC
Contributor

JimiC commented Oct 12, 2017

I checked out what the majority of the dependencies updates was about and it turned out to be dependencies updates, bug fixes, and new features.

I tested this with the editorconfig-vscode extension, in which I contribute by fixing the test cases from time to time, by forcing the vscode package to use the updated dependencies and all looked good.

So I'm confident that there are no breaking changes, but in case I'm horribly wrong, we'll find out pretty quickly.

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Oct 13, 2017

Member

@JimiC we cannot bump the types for node though, they have to stay in sync with the node.js runtime we ship with in VS Code which today is 7.9.0:

image

Member

bpasero commented Oct 13, 2017

@JimiC we cannot bump the types for node though, they have to stay in sync with the node.js runtime we ship with in VS Code which today is 7.9.0:

image

@JimiC

This comment has been minimized.

Show comment
Hide comment
@JimiC

JimiC Oct 13, 2017

Contributor

@bpasero Valid point. I had a look on v7 and v8 definitions of @types/node and in order to not confuse any user with types that are not supported from vscode we better ship v7.

Contributor

JimiC commented Oct 13, 2017

@bpasero Valid point. I had a look on v7 and v8 definitions of @types/node and in order to not confuse any user with types that are not supported from vscode we better ship v7.

@bpasero bpasero merged commit 6500337 into Microsoft:master Oct 13, 2017

1 check passed

license/cla All CLA requirements met.
Details
@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Oct 13, 2017

Member

Thanks

Member

bpasero commented Oct 13, 2017

Thanks

@JimiC JimiC deleted the JimiC:update_depends branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment