New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing against latest Insiders app #89

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
2 participants
@guw
Contributor

guw commented Dec 4, 2017

This change allows setting CODE_VERSION to 'insiders' which will trigger
download of an Insiders build and using that for test execution.

Fixes #88.

Allow testing against latest Insiders app
This change allows setting CODE_VERSION to 'insiders' which will trigger
download of an Insiders build and using that for test execution.

Fixes #88.

Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
@guw

This comment has been minimized.

Show comment
Hide comment
@guw

guw Dec 4, 2017

Contributor

@bpasero Here is a PR. I hijacked the CODE_VERSION variable. Setting it to 'insiders' will download the insiders build and use that for execution.

For simplicity reason I do expect an external entity to clean-up previous .vscode-test downloads when changing the value of CODE_VERSION.

Also, let me know if there is any readme or changelog that needs to be updated.

Contributor

guw commented Dec 4, 2017

@bpasero Here is a PR. I hijacked the CODE_VERSION variable. Setting it to 'insiders' will download the insiders build and use that for execution.

For simplicity reason I do expect an external entity to clean-up previous .vscode-test downloads when changing the value of CODE_VERSION.

Also, let me know if there is any readme or changelog that needs to be updated.

@@ -110,16 +121,16 @@ function getDownloadUrl(clb) {
}
getTag(function (tag) {
return clb(['https://vscode-update.azurewebsites.net', tag, downloadPlatform, 'stable'].join('/'));
return clb(['https://vscode-update.azurewebsites.net', tag, downloadPlatform, (isInsiders ? 'insider' : 'stable')].join('/'));

This comment has been minimized.

@guw

guw Dec 4, 2017

Contributor

If you aren't a fan for the ? operator I can move it into a method and re-use that below as well.

@guw

guw Dec 4, 2017

Contributor

If you aren't a fan for the ? operator I can move it into a method and re-use that below as well.

if(isInsiders) {
windowsExecutable = path.join(testRunFolderAbsolute, 'Code - Insiders');
darwinExecutable = path.join(testRunFolderAbsolute, 'Visual Studio Code - Insiders.app', 'Contents', 'MacOS', 'Electron');
linuxExecutable = path.join(testRunFolderAbsolute, 'VSCode-linux-x64', 'code-insiders');

This comment has been minimized.

@guw

guw Dec 4, 2017

Contributor

I intentionally dropped the special version handling for older versions for the Insiders stream.

@guw

guw Dec 4, 2017

Contributor

I intentionally dropped the special version handling for older versions for the Insiders stream.

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Dec 5, 2017

Member

@guw great, thanks!

Member

bpasero commented Dec 5, 2017

@guw great, thanks!

@bpasero bpasero merged commit 1fa217d into Microsoft:master Dec 5, 2017

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment