New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo and formatting nitpicks #85

Merged
merged 2 commits into from Oct 2, 2017

Conversation

Projects
None yet
2 participants
@gilmoreorless
Contributor

gilmoreorless commented Sep 26, 2017

Firstly, great work on the generator; it was really useful for converting a Sublime Text package over to VS Code.

This PR fixes some minor things that I noticed while using the generator. It has two main parts:

  1. Typos and grammatical nitpicks.
  2. Consistent capitalisation and punctuation in the bullet points of the various vsc-extension-quickstart.md files. The bullet points had a mixture of upper- and lower-case starting letters, and inconsistent application of full stops (periods).

I realise the second part is perhaps overly pedantic. If you’d rather accept just the typo fixes without the reformatting, I’m happy to redo the PR to suit (that’s why they’re separate commits 😉).

@aeschli aeschli merged commit b865288 into Microsoft:master Oct 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@aeschli

This comment has been minimized.

Contributor

aeschli commented Oct 2, 2017

Thanks @gilmoreorless , that was helpful!

@aeschli aeschli added this to the September 2017 milestone Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment