New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy url #16 #24

Merged
merged 2 commits into from Oct 2, 2017

Conversation

Projects
None yet
2 participants
@Ikuyadeu
Contributor

Ikuyadeu commented Sep 18, 2017

Related #16.
I added copy summary and copy url when right click issue.

@chrmarti chrmarti added this to the September 2017 milestone Sep 26, 2017

@chrmarti

This comment has been minimized.

Show comment
Hide comment
@chrmarti

chrmarti Sep 28, 2017

Contributor

Hi @Ikuyadeu, thanks for your contribution!

I can see the Copy URL action being useful. I'm not sure about Copy Summary, because that usually consists of many lines of description and if someone wants to copy from it they are likely to first look at it (on github.com in the browser) and then decide on whether to copy it full or in part. What do you think?

Contributor

chrmarti commented Sep 28, 2017

Hi @Ikuyadeu, thanks for your contribution!

I can see the Copy URL action being useful. I'm not sure about Copy Summary, because that usually consists of many lines of description and if someone wants to copy from it they are likely to first look at it (on github.com in the browser) and then decide on whether to copy it full or in part. What do you think?

@Ikuyadeu

This comment has been minimized.

Show comment
Hide comment
@Ikuyadeu

Ikuyadeu Sep 29, 2017

Contributor

@chrmarti Thank you for your review.
Copy Summary function is for user who doesn't want to switching code window to browser window.
I think some other solutions.

  1. Copy Summary to Copy Full Summary and Copy Summary Header, that can get summary's first line.
  2. Copy Summary to Preview Summary, that open Markdown preview
Contributor

Ikuyadeu commented Sep 29, 2017

@chrmarti Thank you for your review.
Copy Summary function is for user who doesn't want to switching code window to browser window.
I think some other solutions.

  1. Copy Summary to Copy Full Summary and Copy Summary Header, that can get summary's first line.
  2. Copy Summary to Preview Summary, that open Markdown preview
@chrmarti

This comment has been minimized.

Show comment
Hide comment
@chrmarti

chrmarti Sep 29, 2017

Contributor

I want to keep the functionality in the extension small and defer previewing of the summary to the website in the browser. I don't think opening the browser is a bad thing if it does not happen too often.

The current actions in the context menu provide shortcuts for things that do not require additional user interaction to be useful, that keeps the extension simple. Copy URL seems to fit that pattern, Copy Summary (or similar) needs something to preview/show the summary and does not seem to fit the pattern.

Contributor

chrmarti commented Sep 29, 2017

I want to keep the functionality in the extension small and defer previewing of the summary to the website in the browser. I don't think opening the browser is a bad thing if it does not happen too often.

The current actions in the context menu provide shortcuts for things that do not require additional user interaction to be useful, that keeps the extension simple. Copy URL seems to fit that pattern, Copy Summary (or similar) needs something to preview/show the summary and does not seem to fit the pattern.

@Ikuyadeu

This comment has been minimized.

Show comment
Hide comment
@Ikuyadeu

Ikuyadeu Sep 29, 2017

Contributor

@chrmarti Thank you for your suggestion. I understand.
So I will remove only Copy Summary.

Contributor

Ikuyadeu commented Sep 29, 2017

@chrmarti Thank you for your suggestion. I understand.
So I will remove only Copy Summary.

@chrmarti

This comment has been minimized.

Show comment
Hide comment
@chrmarti

chrmarti Sep 29, 2017

Contributor

@Ikuyadeu Great, happy to merge after that.

Contributor

chrmarti commented Sep 29, 2017

@Ikuyadeu Great, happy to merge after that.

@Ikuyadeu

This comment has been minimized.

Show comment
Hide comment
@Ikuyadeu

Ikuyadeu Oct 1, 2017

Contributor

@chrmarti OK, I fixed!

Contributor

Ikuyadeu commented Oct 1, 2017

@chrmarti OK, I fixed!

@Ikuyadeu Ikuyadeu changed the title from Add copy summary and url #16 to Add copy url #16 Oct 1, 2017

@chrmarti chrmarti merged commit ff4c9d9 into Microsoft:master Oct 2, 2017

1 check passed

license/cla All CLA requirements met.
Details
@chrmarti

This comment has been minimized.

Show comment
Hide comment
@chrmarti

chrmarti Oct 2, 2017

Contributor

Thanks @Ikuyadeu !

Contributor

chrmarti commented Oct 2, 2017

Thanks @Ikuyadeu !

@Ikuyadeu Ikuyadeu deleted the Ikuyadeu:extend_tooltip branch Oct 2, 2017

kieferrm added a commit to kieferrm/vscode-github-issues-prs that referenced this pull request Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment