New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gocode is broken on current go git master #1645

Closed
OneOfOne opened this Issue Apr 25, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@OneOfOne
Contributor

OneOfOne commented Apr 25, 2018

Steps to Reproduce:

  1. use current go git master.
  2. get PANIC when you try to auto complete.

Possible fixes:

Just installing either of those will override nsf's gocode and you just can run killall -9 gocode without restarting vscode.

@OneOfOne

This comment has been minimized.

Show comment
Hide comment
@OneOfOne

OneOfOne May 1, 2018

Contributor

With #1607, go-langserver will handle that.

@slimsag @keegancsmith

Contributor

OneOfOne commented May 1, 2018

With #1607, go-langserver will handle that.

@slimsag @keegancsmith

@FiloSottile

This comment has been minimized.

Show comment
Hide comment
@FiloSottile

FiloSottile May 4, 2018

From https://github.com/nsf/gocode/blob/9d1e0378d/README.md:

IMPORTANT: consider switching to https://github.com/mdempsky/gocode if you have problems starting with Go version 1.10, due to changes in binary packages architecture (introduction of package cache) I'm not going to adjust gocode for it for quite some time. There is a higher chance that fork under the given link will have some solution to the problem sooner or later.

FiloSottile commented May 4, 2018

From https://github.com/nsf/gocode/blob/9d1e0378d/README.md:

IMPORTANT: consider switching to https://github.com/mdempsky/gocode if you have problems starting with Go version 1.10, due to changes in binary packages architecture (introduction of package cache) I'm not going to adjust gocode for it for quite some time. There is a higher chance that fork under the given link will have some solution to the problem sooner or later.

@mccolljr

This comment has been minimized.

Show comment
Hide comment
@mccolljr

mccolljr May 30, 2018

Out of curiousity, has this been addressed? Is this package going to move to github.com/mdempsky/gocode? Manually installing and switching to that fork of gocode stops the PANIC messages and gets me completion again. Even gocode's original author recommends switching to the fork, so I think this would be the right move. Or, at least provide a setting for which fork to use?

mccolljr commented May 30, 2018

Out of curiousity, has this been addressed? Is this package going to move to github.com/mdempsky/gocode? Manually installing and switching to that fork of gocode stops the PANIC messages and gets me completion again. Even gocode's original author recommends switching to the fork, so I think this would be the right move. Or, at least provide a setting for which fork to use?

@localvar

This comment has been minimized.

Show comment
Hide comment
@localvar

localvar Jun 3, 2018

just FYI: To improve the performance of https://github.com/mdempsky/gocode, I create another temporary folk at: https://github.com/localvar/gocode

localvar commented Jun 3, 2018

just FYI: To improve the performance of https://github.com/mdempsky/gocode, I create another temporary folk at: https://github.com/localvar/gocode

@ramya-rao-a

This comment has been minimized.

Show comment
Hide comment
@ramya-rao-a

ramya-rao-a Jun 3, 2018

Member

Well, I did give this a try, but the completion tests for all versions of Go started failing in travis.
See https://github.com/Microsoft/vscode-go/commits/new-gocode

If anyone can figure that out, then yes, we can move to github.com/mdempsky/gocode

Member

ramya-rao-a commented Jun 3, 2018

Well, I did give this a try, but the completion tests for all versions of Go started failing in travis.
See https://github.com/Microsoft/vscode-go/commits/new-gocode

If anyone can figure that out, then yes, we can move to github.com/mdempsky/gocode

@ramya-rao-a

This comment has been minimized.

Show comment
Hide comment
@ramya-rao-a

ramya-rao-a Jun 6, 2018

Member

Fixed with #1710 thanks to @m90
The fix is out in today's update to the Go extension (0.6.82)

Member

ramya-rao-a commented Jun 6, 2018

Fixed with #1710 thanks to @m90
The fix is out in today's update to the Go extension (0.6.82)

@ramya-rao-a ramya-rao-a closed this Jun 6, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.