Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
AutoComplete un-imported packages based on go.mod #1902
changed the title from
Autocomplete dependencies based on go.mod
Autocomplete un-imported packages based on go.mod
Sep 1, 2018
Thanks for jumping on this @uudashr!
Correct me if I am wrong, I was under the assumption that when modules are enabled, then one can only import packages that are defined in the module or the ones in the standard library.
With the current change, packages from the GOPATH will also be included regardless of whether the current file is under the GOPATH or not
Ya.. correct. Just figure out.
So I am guessing we need to
The identification of whether current package is using modules or not, should be done in
I cloned https://github.com/golang/example/ outside of my GOPATH
Since this PR relies on
@ramya-rao-a what is the goal of
What if we are opening file under go modules project, does the result going to be different ex: GOROOT + modules
@uudashr Turns out that if you use
Also, the current solution in this PR doesn't make use of the caching system we put in place earlier.
I am closing this PR in favor of 0a9001f which covers the above concerns.
Do take a look at that commit and share any feedback you have.