Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Improve error handling of test coverage #721

Merged
merged 1 commit into from Jan 13, 2017

Conversation

nochso
Copy link
Contributor

@nochso nochso commented Jan 13, 2017

  • The previous condition did not catch any errors when go test for retrieving coverage failed.
  • Use an output channel to show the error message. showInformationMessage is only good for single lines.

Fixes #350

@msftclas
Copy link

Hi @nochso, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@ramya-rao-a
Copy link
Contributor

@nochso You have linting errors that is breaking the build. Can you fix them?
Run npm run lint to see the linting errors

- The previous condition did not catch any errors when `go test` for retrieving coverage failed.
- Use an output channel to show the error message. showInformationMessage is only good for single lines.

Fixes microsoft#350
@nochso
Copy link
Contributor Author

nochso commented Jan 13, 2017

@ramya-rao-a I've fixed the linting errors and squashed the commit.

@ramya-rao-a ramya-rao-a merged commit f4d5178 into microsoft:master Jan 13, 2017
@ramya-rao-a
Copy link
Contributor

Thanks @nochso

@nochso nochso deleted the coverage-error branch January 13, 2017 23:50
mattetti added a commit to mattetti/vscode-go that referenced this pull request Jan 16, 2017
…ild-i

* 'master' of github.com:Microsoft/vscode-go:
  Moved debugging doc to a separate wiki
  Make a copy of process.env when setting VSCODE_GOTOOLS
  Debugger cannot read settings
  Improve error handling of test coverage (microsoft#721)
  Use proper plurality in output (microsoft#720)
  Fixes microsoft#303 Dont run test if current file is  not test file
  Added a note on how to debug single tests
  Allow Go tools to be installed in a separate GOPATH (microsoft#351)
  Fix typo in README.md (microsoft#715)
  Honor the 'cwd' launch configuration argument (microsoft#714)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants