Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Use settings for separate location for installing Go tools #737

Merged
merged 1 commit into from Jan 21, 2017

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Jan 21, 2017

See #5 for the discussion on the need for a separate location to install Go tools instead of the user's GOPATH.

See #351 for the implementation using env vars and further talk of how a VS Code setting is better instead of env var

This PR is to use VS Code setting where user can provide a location for installing the Go tools.
gometalinter is an exception to this rule and will get installed in the user's GOPATH always.
This is because gometalinter expects all the linters it uses to be in the user's GOPATH.

Users need to install dlv manually as always and is out of this disucssion

cc @roblourens

@@ -388,6 +388,11 @@
"godoc",
"gogetdoc"
]
},
"go.toolsGopath": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital P?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe gopath is like one word, either way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel different everytime I think about it :(

@ramya-rao-a ramya-rao-a merged commit 2a93232 into microsoft:master Jan 21, 2017
@ramya-rao-a ramya-rao-a deleted the separate-gotools-path branch January 22, 2017 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants