Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js-beautify to 1.8.0-rc4 #31

Merged
merged 1 commit into from Aug 6, 2018

Conversation

@bitwiseman
Copy link
Contributor

commented Aug 3, 2018

@aeschli
1.8.0-rc4 Fixes several breaking bugs in 1.8.0-rc2. In particular beautify-web/js-beautify#1464 - where element casing was not being preserved.

Please consider taking this update.

@msftclas

This comment has been minimized.

Copy link

commented Aug 3, 2018

CLA assistant check
All CLA requirements met.

@aeschli aeschli merged commit 37f3da3 into microsoft:master Aug 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@aeschli

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

@bitwiseman Thanks a lot!

@aeschli aeschli added this to the August 2018 milestone Aug 6, 2018

@aeschli

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

@bitwiseman Should I surface wrapAttributes: 'aligned-multiple' and wrapAttributesIndentSize, or do you plan to replace these very soon?
Also, I couldn't find a compact description of what aligned-multiple does...

@bitwiseman

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2018

@aeschli

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

Thanks a lot! I'll surface the new settings ASAP.

@bitwiseman bitwiseman deleted the bitwiseman:js-beautify-rc4 branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.