New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.9.0-beta1 #43

Merged
merged 8 commits into from Jan 28, 2019

Conversation

Projects
None yet
2 participants
@bitwiseman
Copy link
Contributor

bitwiseman commented Jan 14, 2019

1.9.0 will be out soon.

It addresses a number of line wrapping issues (such as beautify-web/js-beautify#1324). If we can update this plugin to 1.9.0-beta1, it will give the next release a lot of good testing.

@bitwiseman

This comment has been minimized.

Copy link
Contributor Author

bitwiseman commented Jan 14, 2019

I'm unclear why this failed. Any help would be appreciated.

bitwiseman added some commits Jan 14, 2019

Trim left of input
The behavior of the html beautifier changed to preserve leading
whitespace and use it to determing base indent level.
Trimming the leading whitespace makes beautifier behave the same
as it was previously.
Pass tab size instead of placeholder
When indent_char is tab, indent_size is now used to calculate the number
of columns an indent uses.  This matters for wrap attributes indenting
and for line length wrapping calculations.
Allow formatting to end inside an element
Previously, if a range started and ended inside an element it would not be formatted.
However, if it started inside an element but ended outside it would format.

With this change as long as the range starts outside on element it will format.
This is safe as the beautifier formats incomplete html just fine up to where it ends.
Update to 1.9.0-beta2
Improved support for php, handlebars, and other template languages.
This support is far from complete but generally works for
inline use cases where formatting inside the templating
only needs preserving.

@bitwiseman bitwiseman force-pushed the bitwiseman:update-1.9.0-beta1 branch from ceb15f4 to 83e6a8e Jan 17, 2019

@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented Jan 26, 2019

Thanks a lot @bitwiseman, I'll merge on Monday for the January Build

@bitwiseman

This comment has been minimized.

Copy link
Contributor Author

bitwiseman commented Jan 26, 2019

@aeschli
Excellent, thanks. This is pretty major change.
It has passed on my tests of course, but if you have any time to run some manual tests on it, that would be much appreciated.

@aeschli aeschli merged commit 069cb75 into Microsoft:master Jan 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@aeschli aeschli added this to the December/January 2019 milestone Jan 28, 2019

@bitwiseman bitwiseman deleted the bitwiseman:update-1.9.0-beta1 branch Jan 29, 2019

@bitwiseman

This comment has been minimized.

Copy link
Contributor Author

bitwiseman commented Jan 29, 2019

@aeschli Here's some highlights you can use for the release:
https://github.com/beautify-web/js-beautify/releases/tag/v1.9.0-beta4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment