New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wrap in array and object completions #29

Merged
merged 3 commits into from Oct 22, 2018

Conversation

Projects
None yet
3 participants
@FloEdelmann
Contributor

FloEdelmann commented Oct 2, 2018

@aeschli

This comment has been minimized.

Contributor

aeschli commented Oct 2, 2018

@FloEdelmann Please update the tests as well.

@aeschli aeschli added this to the October 2018 milestone Oct 2, 2018

FloEdelmann added some commits Oct 2, 2018

@msftclas

This comment has been minimized.

msftclas commented Oct 2, 2018

CLA assistant check
All CLA requirements met.

@FloEdelmann

This comment has been minimized.

Contributor

FloEdelmann commented Oct 2, 2018

@aeschli The tests (and another place where the same completions are suggested) are now fixed.

Unfortunately, the Travis CI tests still fail. Am I right that that is not related to my changes?

@FloEdelmann

This comment has been minimized.

Contributor

FloEdelmann commented Oct 19, 2018

@aeschli Any updates on this? Is it possible that this will make it into the October Release?

@aeschli aeschli merged commit 51d84b0 into Microsoft:master Oct 22, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Details
@aeschli

This comment has been minimized.

Contributor

aeschli commented Oct 22, 2018

merged, thanks!

@FloEdelmann

This comment has been minimized.

Contributor

FloEdelmann commented Oct 22, 2018

Nice, thank you!

@FloEdelmann FloEdelmann deleted the FloEdelmann:patch-1 branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment