New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that the workspace.applyEdit feature is enabled in the client #264

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@rcjsuen
Contributor

rcjsuen commented Oct 15, 2017

Not sure if this is the right way of going about it but it does address#263.

Specify that the applyEdit feature is enabled
As the vscode-languageclient package supports the handling of
workspace/applyEdit requests, it should make it known in the initial
handshake that is sent to the server.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Oct 15, 2017

@rcjsuen,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

msftclas commented Oct 15, 2017

@rcjsuen,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dbaeumer

This comment has been minimized.

Show comment
Hide comment
@dbaeumer

dbaeumer Oct 16, 2017

Member

Thanks. This got lost when introducing the feature structure for the client.

Member

dbaeumer commented Oct 16, 2017

Thanks. This got lost when introducing the feature structure for the client.

@dbaeumer dbaeumer merged commit 42a04f6 into Microsoft:master Oct 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@rcjsuen rcjsuen deleted the rcjsuen:applyEdit branch Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment