New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming ProtocolConnetion to ProtocolConnection #265

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@object88
Contributor

object88 commented Oct 15, 2017

Reading through the code, I found a typo in one of the object names. It's unclear to me how far outside of this project this might extend, however. Please let me know if there is any more work around this.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Oct 15, 2017

@object88,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

msftclas commented Oct 15, 2017

@object88,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Oct 15, 2017

CLA assistant check
All CLA requirements met.

msftclas commented Oct 15, 2017

CLA assistant check
All CLA requirements met.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Oct 15, 2017

@object88, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

msftclas commented Oct 15, 2017

@object88, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@msftclas msftclas added cla-signed and removed cla-required labels Oct 15, 2017

@dbaeumer

This comment has been minimized.

Show comment
Hide comment
@dbaeumer

dbaeumer Oct 16, 2017

Member

Thanks. To make this non breaking and will add a type def for the old name.

Member

dbaeumer commented Oct 16, 2017

Thanks. To make this non breaking and will add a type def for the old name.

@dbaeumer dbaeumer merged commit c5d57c1 into Microsoft:master Oct 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment