Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that onWillSave handler capabilities reqs #275

Merged
merged 2 commits into from Nov 23, 2017
Merged

Document that onWillSave handler capabilities reqs #275

merged 2 commits into from Nov 23, 2017

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Nov 18, 2017 •
edited

related to #274

@msftclas
Copy link

@rictic,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dbaeumer
Copy link
Member

@rictic thanks for the PR. However this text is not 100% correct. Besides setting the capability on server initialize the server can always register dynamically later on. Can you add a sentence about this as well.

@dbaeumer dbaeumer self-assigned this Nov 20, 2017
@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Nov 20, 2017
@rictic
Copy link
Contributor Author

rictic commented Nov 22, 2017 •
edited

+1. PTAL

@dbaeumer
Copy link
Member

Thanks!

@dbaeumer dbaeumer merged commit fdbd8f7 into microsoft:master Nov 23, 2017
@rictic rictic deleted the patch-1 branch November 23, 2017 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dbaeumer dbaeumer

Labels
info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rictic @msftclas @dbaeumer