New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that onWillSave handler capabilities reqs #275

Merged
merged 2 commits into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@rictic
Contributor

rictic commented Nov 18, 2017

related to #274

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Nov 18, 2017

@rictic,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

msftclas commented Nov 18, 2017

@rictic,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dbaeumer

This comment has been minimized.

Show comment
Hide comment
@dbaeumer

dbaeumer Nov 20, 2017

Member

@rictic thanks for the PR. However this text is not 100% correct. Besides setting the capability on server initialize the server can always register dynamically later on. Can you add a sentence about this as well.

Member

dbaeumer commented Nov 20, 2017

@rictic thanks for the PR. However this text is not 100% correct. Besides setting the capability on server initialize the server can always register dynamically later on. Can you add a sentence about this as well.

@dbaeumer dbaeumer self-assigned this Nov 20, 2017

@rictic

This comment has been minimized.

Show comment
Hide comment
@rictic

rictic Nov 22, 2017

Contributor

+1. PTAL

Contributor

rictic commented Nov 22, 2017

+1. PTAL

@dbaeumer

This comment has been minimized.

Show comment
Hide comment
@dbaeumer

dbaeumer Nov 23, 2017

Member

Thanks!

Member

dbaeumer commented Nov 23, 2017

Thanks!

@dbaeumer dbaeumer merged commit fdbd8f7 into Microsoft:master Nov 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@rictic rictic deleted the rictic:patch-1 branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment